Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js b/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
index 85d3d6f638c27d8651e141b45350916685ef4b4d..f5771ce939bdb82724a935d50817660502bf5e49 100644
--- a/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
+++ b/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
@@ -210,7 +210,7 @@ Devices.DevicesView.DiscoveryView = class extends UI.VBox {
this.contentElement.createChild('div', 'hbox device-text-row').createChild('div', 'view-title').textContent =
Common.UIString('Settings');
- var discoverUsbDevicesCheckbox = createCheckboxLabel(Common.UIString('Discover USB devices'));
+ var discoverUsbDevicesCheckbox = UI.createCheckboxLabel(Common.UIString('Discover USB devices'));
discoverUsbDevicesCheckbox.classList.add('usb-checkbox');
this.element.appendChild(discoverUsbDevicesCheckbox);
this._discoverUsbDevicesCheckbox = discoverUsbDevicesCheckbox.checkboxElement;
@@ -223,7 +223,7 @@ Devices.DevicesView.DiscoveryView = class extends UI.VBox {
Common.UIString('remote debugging documentation.')));
var portForwardingHeader = this.element.createChild('div', 'port-forwarding-header');
- var portForwardingEnabledCheckbox = createCheckboxLabel(Common.UIString('Port forwarding'));
+ var portForwardingEnabledCheckbox = UI.createCheckboxLabel(Common.UIString('Port forwarding'));
portForwardingEnabledCheckbox.classList.add('port-forwarding-checkbox');
portForwardingHeader.appendChild(portForwardingEnabledCheckbox);
this._portForwardingEnabledCheckbox = portForwardingEnabledCheckbox.checkboxElement;
@@ -244,7 +244,7 @@ Devices.DevicesView.DiscoveryView = class extends UI.VBox {
this._list.show(this.element);
this.element.appendChild(
- createTextButton(Common.UIString('Add rule'), this._addRuleButtonClicked.bind(this), 'add-rule-button'));
+ UI.createTextButton(Common.UIString('Add rule'), this._addRuleButtonClicked.bind(this), 'add-rule-button'));
/** @type {!Array<!Adb.PortForwardingRule>} */
this._portForwardingConfig = [];
@@ -473,7 +473,7 @@ Devices.DevicesView.DeviceView = class extends UI.VBox {
newTabInput.type = 'text';
newTabInput.placeholder = Common.UIString('Enter URL');
newTabInput.addEventListener('keydown', newTabKeyDown, false);
- var newTabButton = createTextButton(Common.UIString('Open'), openNewTab);
+ var newTabButton = UI.createTextButton(Common.UIString('Open'), openNewTab);
newTabRow.appendChild(newTabButton);
var pages = element.createChild('div', 'device-page-list vbox');
@@ -575,7 +575,8 @@ Devices.DevicesView.DeviceView = class extends UI.VBox {
var titleRow = element.createChild('div', 'device-page-title-row');
var title = titleRow.createChild('div', 'device-page-title');
- var inspect = createTextButton(Common.UIString('Inspect'), doAction.bind(null, 'inspect'), 'device-inspect-button');
+ var inspect =
+ UI.createTextButton(Common.UIString('Inspect'), doAction.bind(null, 'inspect'), 'device-inspect-button');
titleRow.appendChild(inspect);
var toolbar = new UI.Toolbar('');

Powered by Google App Engine
This is Rietveld 408576698