third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

index 6318a74a18db077d8f76fe3ff43fb0334504b85f..a4dd3957e5a8f469e3fb1e9d49d9a24e70279679 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

@@ -224,10 +224,11 @@ Components.FilmStripView.Dialog = class extends UI.VBox {

var footerElement = this.contentElement.createChild('div', 'filmstrip-dialog-footer');

footerElement.createChild('div', 'flex-auto');

var prevButton =

- createTextButton('\u25C0', this._onPrevFrame.bind(this), undefined, Common.UIString('Previous frame'));

+ UI.createTextButton('\u25C0', this._onPrevFrame.bind(this), undefined, Common.UIString('Previous frame'));

footerElement.appendChild(prevButton);

this._timeLabel = footerElement.createChild('div', 'filmstrip-dialog-label');

- var nextButton = createTextButton('\u25B6', this._onNextFrame.bind(this), undefined, Common.UIString('Next frame'));

+ var nextButton =

+ UI.createTextButton('\u25B6', this._onNextFrame.bind(this), undefined, Common.UIString('Next frame'));

footerElement.appendChild(nextButton);

footerElement.createChild('div', 'flex-auto');