third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

index 35ef76433bd986824302982251e6e5a0e31ddb60..f573242e2c3469e68b069fda8c160fc4a57cf49e 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

@@ -209,7 +209,7 @@ Audits.AuditLauncherView = class extends UI.VBox {

* @param {string=} id

_createCategoryElement(title, id) {

- var labelElement = createCheckboxLabel(title);

+ var labelElement = UI.createCheckboxLabel(title);

if (id) {

labelElement.id = this._categoryIdPrefix + id;

labelElement.checkboxElement.addEventListener('click', this._boundCategoryClickListener, false);

@@ -248,18 +248,18 @@ Audits.AuditLauncherView = class extends UI.VBox {

this._buttonContainerElement = this._contentElement.createChild('div', 'button-container');

- var radio = createRadioLabel('audit-mode', Common.UIString('Audit Present State'), true);

+ var radio = UI.createRadioLabel('audit-mode', Common.UIString('Audit Present State'), true);

this._buttonContainerElement.appendChild(radio);

this._auditPresentStateElement = radio.radioElement;

- radio = createRadioLabel('audit-mode', Common.UIString('Reload Page and Audit on Load'));

+ radio = UI.createRadioLabel('audit-mode', Common.UIString('Reload Page and Audit on Load'));

this._buttonContainerElement.appendChild(radio);

this._auditReloadedStateElement = radio.radioElement;

- this._launchButton = createTextButton(Common.UIString('Run'), this._launchButtonClicked.bind(this));

+ this._launchButton = UI.createTextButton(Common.UIString('Run'), this._launchButtonClicked.bind(this));

this._buttonContainerElement.appendChild(this._launchButton);

- this._clearButton = createTextButton(Common.UIString('Clear'), this._clearButtonClicked.bind(this));

+ this._clearButton = UI.createTextButton(Common.UIString('Clear'), this._clearButtonClicked.bind(this));

this._buttonContainerElement.appendChild(this._clearButton);

this._selectAllClicked(this._selectAllCheckboxElement.checked);