Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com). 3 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * Copyright (C) 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2011 Google Inc. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 10 *
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 this._prevButtonElement.addEventListener('click', this._onPreviousClick.bind (this), false); 126 this._prevButtonElement.addEventListener('click', this._onPreviousClick.bind (this), false);
127 127
128 this._replaceAllButtonElement = 128 this._replaceAllButtonElement =
129 this._secondRowElement.createChild('td').createChild('button', 'search-a ction-button'); 129 this._secondRowElement.createChild('td').createChild('button', 'search-a ction-button');
130 this._replaceAllButtonElement.textContent = Common.UIString('Replace All'); 130 this._replaceAllButtonElement.textContent = Common.UIString('Replace All');
131 this._replaceAllButtonElement.addEventListener('click', this._replaceAll.bin d(this), false); 131 this._replaceAllButtonElement.addEventListener('click', this._replaceAll.bin d(this), false);
132 132
133 // Column 4 133 // Column 4
134 this._replaceElement = this._firstRowElement.createChild('td').createChild(' span'); 134 this._replaceElement = this._firstRowElement.createChild('td').createChild(' span');
135 135
136 this._replaceLabelElement = createCheckboxLabel(Common.UIString('Replace')); 136 this._replaceLabelElement = UI.createCheckboxLabel(Common.UIString('Replace' ));
137 this._replaceCheckboxElement = this._replaceLabelElement.checkboxElement; 137 this._replaceCheckboxElement = this._replaceLabelElement.checkboxElement;
138 this._uniqueId = ++UI.SearchableView._lastUniqueId; 138 this._uniqueId = ++UI.SearchableView._lastUniqueId;
139 var replaceCheckboxId = 'search-replace-trigger' + this._uniqueId; 139 var replaceCheckboxId = 'search-replace-trigger' + this._uniqueId;
140 this._replaceCheckboxElement.id = replaceCheckboxId; 140 this._replaceCheckboxElement.id = replaceCheckboxId;
141 this._replaceCheckboxElement.addEventListener('change', this._updateSecondRo wVisibility.bind(this), false); 141 this._replaceCheckboxElement.addEventListener('change', this._updateSecondRo wVisibility.bind(this), false);
142 142
143 this._replaceElement.appendChild(this._replaceLabelElement); 143 this._replaceElement.appendChild(this._replaceLabelElement);
144 144
145 // Column 5 145 // Column 5
146 var cancelButtonElement = this._firstRowElement.createChild('td').createChil d('button', 'search-action-button'); 146 var cancelButtonElement = this._firstRowElement.createChild('td').createChil d('button', 'search-action-button');
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 // Silent catch. 611 // Silent catch.
612 } 612 }
613 613
614 // Otherwise just do a plain text search. 614 // Otherwise just do a plain text search.
615 if (!regex) 615 if (!regex)
616 regex = createPlainTextSearchRegex(query, modifiers); 616 regex = createPlainTextSearchRegex(query, modifiers);
617 617
618 return regex; 618 return regex;
619 } 619 }
620 }; 620 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698