Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: components/reading_list/ios/favicon_web_state_dispatcher.h

Issue 2604773002: Create distiller files for Reading List. (Closed)
Patch Set: feedback Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/reading_list/ios/BUILD.gn ('k') | ios/chrome/browser/dom_distiller/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/favicon_web_state_dispatcher.h
diff --git a/components/dom_distiller/ios/favicon_web_state_dispatcher.h b/components/reading_list/ios/favicon_web_state_dispatcher.h
similarity index 50%
rename from components/dom_distiller/ios/favicon_web_state_dispatcher.h
rename to components/reading_list/ios/favicon_web_state_dispatcher.h
index c34e6985a12377b207e7d4c1044e5512ec1430a0..4ffcbae2bfd2b63003cdd0415fce4101339a5566 100644
--- a/components/dom_distiller/ios/favicon_web_state_dispatcher.h
+++ b/components/reading_list/ios/favicon_web_state_dispatcher.h
@@ -2,33 +2,32 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_DOM_DISTILLER_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
-#define COMPONENTS_DOM_DISTILLER_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
+#ifndef COMPONENTS_READING_LIST_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
+#define COMPONENTS_READING_LIST_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
namespace web {
class WebState;
}
-namespace dom_distiller {
+namespace reading_list {
// Dispatcher for WebState having a Favicon Driver, with BookmarkModel and
-// HistoryService attached, as observer. The Webstates are kept alive between
-// their creation and their return. After a WebState is returned, the dispatcher
-// keeps it alive long enough for it to download the favicons.
+// HistoryService attached, as observer. After a WebState is returned, the
+// dispatcher keeps it alive long enough for it to download the favicons.
class FaviconWebStateDispatcher {
public:
FaviconWebStateDispatcher() {}
virtual ~FaviconWebStateDispatcher() {}
// Returns a WebState with a Favicon Driver attached.
- virtual web::WebState* RequestWebState() = 0;
+ virtual std::unique_ptr<web::WebState> RequestWebState() = 0;
// Called to return a WebState. The WebState should not be used after being
// returned.
- virtual void ReturnWebState(web::WebState* web_state) = 0;
+ virtual void ReturnWebState(std::unique_ptr<web::WebState> web_state) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(FaviconWebStateDispatcher);
};
-} // namespace dom_distiller
+} // namespace reading_list
-#endif // COMPONENTS_DOM_DISTILLER_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
+#endif // COMPONENTS_READING_LIST_IOS_FAVICON_WEB_STATE_DISPATCHER_H_
« no previous file with comments | « components/reading_list/ios/BUILD.gn ('k') | ios/chrome/browser/dom_distiller/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698