Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.h

Issue 2604773002: Create distiller files for Reading List. (Closed)
Patch Set: feedback Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_page_ios.h
diff --git a/components/dom_distiller/ios/distiller_page_ios.h b/components/dom_distiller/ios/distiller_page_ios.h
index ddd55f31954c92a83aa7b78bcc8dc27b34e64af5..5bad113052e5f9571bdd37dad842d9264057e5a6 100644
--- a/components/dom_distiller/ios/distiller_page_ios.h
+++ b/components/dom_distiller/ios/distiller_page_ios.h
@@ -10,10 +10,14 @@
#include "base/memory/weak_ptr.h"
#include "components/dom_distiller/core/distiller_page.h"
-#include "components/dom_distiller/ios/favicon_web_state_dispatcher.h"
#include "ios/web/public/web_state/web_state_observer.h"
#include "url/gurl.h"
+namespace web {
+class BrowserState;
+class WebState;
+}
+
namespace dom_distiller {
class DistillerWebStateObserver;
@@ -22,19 +26,27 @@ class DistillerWebStateObserver;
// content.
class DistillerPageIOS : public DistillerPage {
public:
- explicit DistillerPageIOS(FaviconWebStateDispatcher* web_state_dispatcher);
+ explicit DistillerPageIOS(web::BrowserState* browser_state);
~DistillerPageIOS() override;
protected:
bool StringifyOutput() override;
void DistillPageImpl(const GURL& url, const std::string& script) override;
- private:
- friend class DistillerWebStateObserver;
+ // Sets the WebState that will be used for the distillation. Do not call
+ // between |DistillPageImpl| and |OnDistillationDone|.
+ virtual void AttachWebState(std::unique_ptr<web::WebState> web_state);
+
+ // Release the WebState used for distillation. Do not call between
+ // |DistillPageImpl| and |OnDistillationDone|.
+ virtual std::unique_ptr<web::WebState> DetachWebState();
// Called by |web_state_observer_| once the page has finished loading.
- void OnLoadURLDone(web::PageLoadCompletionStatus load_completion_status);
+ virtual void OnLoadURLDone(
+ web::PageLoadCompletionStatus load_completion_status);
+ private:
+ friend class DistillerWebStateObserver;
// Called once the |script_| has been evaluated on the page.
void HandleJavaScriptResult(id result);
@@ -43,8 +55,8 @@ class DistillerPageIOS : public DistillerPage {
GURL url_;
std::string script_;
- web::WebState* web_state_;
- FaviconWebStateDispatcher* web_state_dispatcher_;
+ web::BrowserState* browser_state_;
+ std::unique_ptr<web::WebState> web_state_;
std::unique_ptr<DistillerWebStateObserver> web_state_observer_;
base::WeakPtrFactory<DistillerPageIOS> weak_ptr_factory_;
};
« no previous file with comments | « components/dom_distiller/ios/distiller_page_factory_ios.mm ('k') | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698