ios/chrome/browser/dom_distiller/distiller_viewer.h - Issue 2604773002: Create distiller files for Reading List.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/dom_distiller/distiller_viewer.h

Issue 2604773002: Create distiller files for Reading List. (Closed)

Patch Set: Feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/dom_distiller/distiller_viewer.h

diff --git a/ios/chrome/browser/dom_distiller/distiller_viewer.h b/ios/chrome/browser/dom_distiller/distiller_viewer.h

index 639b7ea66770ba92dff110b5d4194d5df7a4880b..6fdc21c90f3f9a73d76ca7751b00355823022796 100644

--- a/ios/chrome/browser/dom_distiller/distiller_viewer.h

+++ b/ios/chrome/browser/dom_distiller/distiller_viewer.h

@@ -54,7 +54,8 @@ class DistillerViewer : public DistillerViewerInterface {

DistillerViewer(dom_distiller::DomDistillerService* distillerService,

PrefService* prefs,

const GURL& url,

- const DistillationFinishedCallback& callback);

+ const DistillationFinishedCallback& callback,

+ const DistillerPageFactory* factory);

noyau (Ping after 24h) 2017/01/02 09:52:49 This does some magic when nil, can you add a comme

Olivier 2017/01/02 11:40:03 Done. I prefer to let the possibility to pass null

~DistillerViewer() override;

void OnArticleReady(