content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 2604763002: Fix crash when forwarding a request to a null service worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2604763002: Fix crash when forwarding a request to a null service worker. (Closed)

Patch Set: fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 6e518aea19186ce1c2dc494f809bf2945a466517..0ce78e4c88bc0ca2f065cb31d8e6ee131970788b 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -291,7 +291,7 @@ class ServiceWorkerURLRequestJobTest

void MainResourceLoadFailed() override {

CHECK(provider_host_);

// Detach the controller so subresource requests also skip the worker.

- provider_host_->NotifyControllerLost(false /* was_deleted */);

+ provider_host_->NotifyControllerLost();

}

// Runs a request where the active worker starts a request in ACTIVATING state