Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2604753002: Subzero: Fix a build error against LLVM trunk. (Closed)

Created:
3 years, 12 months ago by Jim Stichnoth
Modified:
3 years, 12 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a build error against LLVM trunk. LLVM trunk commit a5479197371e169bc676e0e570f2a994329f8773 split include/llvm/Bitcode/ReaderWriter.h into two separate header files. This CL hacks it back, in a sense. With this change (along with the rest of the recent fixes), Subzero builds against the latest LLVM trunk - 759dd39154f0bbf1adc87bf613c95f9564f64aa8 at this writing. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c78be4ec9c4a1d34d0abed50de0de37a87b4accc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A pnacl-llvm/include/llvm/Bitcode/ReaderWriter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
3 years, 12 months ago (2016-12-26 22:38:24 UTC) #3
Karl
lgtm
3 years, 12 months ago (2016-12-27 00:38:27 UTC) #4
Jim Stichnoth
3 years, 12 months ago (2016-12-27 04:10:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c78be4ec9c4a1d34d0abed50de0de37a87b4accc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698