SharedWorker: Clean up SharedWorkerHost

content/browser/shared_worker/shared_worker_host.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_HOST_H_
 #define CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_HOST_H_
 
 #include <list>
 #include <memory>
 #include <utility>
@@ skipping 19 matching lines @@
 // The SharedWorkerHost is the interface that represents the browser side of
 // the browser <-> worker communication channel.
 class SharedWorkerHost {
  public:
   SharedWorkerHost(SharedWorkerInstance* instance,
                    SharedWorkerMessageFilter* filter,
                    int worker_route_id);
   ~SharedWorkerHost();
 
   // Sends |message| to the SharedWorker.
-  bool Send(IPC::Message* message);
+  bool Send(std::unique_ptr<IPC::Message> message);

[kinuko, 2016/12/27 15:38:29]

This generally follows IPC::Sender pattern, it's fine but just passing through
ptr is more common

[nhiroki, 2016/12/28 02:20:37]

I reverted this change because I plan to mojofy shared worker anytime soon and
this pattern will be gone regardless of this change.

 
   // Starts the SharedWorker in the renderer process which is associated with
   // |filter_|.
   void Start(bool pause_on_start);
 
   // Returns true iff the given message from a renderer process was forwarded to
   // the worker.
   bool FilterMessage(const IPC::Message& message,
                      SharedWorkerMessageFilter* filter);
 
@@ skipping 83 matching lines @@
   bool closed_;
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<SharedWorkerHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SharedWorkerHost);
 };
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_HOST_H_