Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 260463003: No need to delete ax subtree when new node is added. (Closed)

Created:
6 years, 7 months ago by dmazzoni
Modified:
6 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews
Visibility:
Public.

Description

No need to delete ax subtree when new node is added. AXTreeSerializer was instructing its client to delete the whole subtree whenever it got a notification on a new node, but that isn't actually necessary. It was causing the whole tree to be recreated unneccessarily. Existing unit tests still pass, and they're comprehensive. BUG=368295 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/accessibility/ax_tree_serializer.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
6 years, 7 months ago (2014-04-29 16:45:55 UTC) #1
David Tseng
lgtm
6 years, 7 months ago (2014-04-29 17:30:00 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-04-29 17:31:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/260463003/1
6 years, 7 months ago (2014-04-29 17:32:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 23:02:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 23:02:42 UTC) #6
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-04-30 05:43:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/260463003/1
6 years, 7 months ago (2014-04-30 05:44:01 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:45:34 UTC) #9
Message was sent while issue was closed.
Change committed as 267096

Powered by Google App Engine
This is Rietveld 408576698