Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2604563002: Fix bug when transitioning from an empty to a non-empty password list (Closed)

Created:
3 years, 12 months ago by vabr (Chromium)
Modified:
3 years, 12 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, kolos1
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix bug when transitioning from an empty to a non-empty password list This change fixes a bug that occurs when a list transitions from an empty to a non-empty state. Before this change, the entries of the list were updated before its visibility, which causes |List.redraw()| to skip adding items to the viewport when the list was hidden. Now the visibility will be updated first, leading to correct behavior. BUG=672869 R=dbeam@chromium.org CC=kolos@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2571443002 Cr-Commit-Position: refs/heads/master@{#440048} (cherry picked from commit 0edd353c07b8cebe483ec64f5e1abe638001d2d4) Committed: https://chromium.googlesource.com/chromium/src/+/d446c28066e5c0e524f0420125207d75da682299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/browser/resources/options/password_manager.js View 3 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
3 years, 12 months ago (2016-12-23 10:12:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d446c28066e5c0e524f0420125207d75da682299.

Powered by Google App Engine
This is Rietveld 408576698