Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4625)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

Issue 2604543002: WebContentsObserver and TabObserver update for PlzNavigate (Closed)
Patch Set: Code with new API without any real hookup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
index 40b364c30b3946090ad021ac70123f5fe07eccea..85838e4516fde14b625af6d7ebb140838d645c8a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
@@ -98,7 +98,16 @@ public class EmptyTabObserver implements TabObserver {
boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) { }
@Override
- public void didFirstVisuallyNonEmptyPaint(Tab tab) { }
+ public void onDidStartNavigation(
+ Tab tab, String url, boolean isInMainFrame, boolean isErrorPage) {}
+
+ @Override
+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage, boolean isReload,
+ int errorCode) {}
+
+ @Override
+ public void didFirstVisuallyNonEmptyPaint(Tab tab) {}
@Override
public void onDidChangeThemeColor(Tab tab, int color) { }

Powered by Google App Engine
This is Rietveld 408576698