Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Actually optimize for OCSP Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 5c3923de3571a628e409cb605d1e9df69f8cee71..165c5d28180da09ffe953d21080c2a2dca7952b0 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -60,7 +60,7 @@
#include "net/base/url_util.h"
#include "net/cert/ct_policy_enforcer.h"
#include "net/cert/ct_policy_status.h"
-#include "net/cert/ct_verifier.h"
+#include "net/cert/do_nothing_ct_verifier.h"
#include "net/cert/ev_root_ca_metadata.h"
#include "net/cert/mock_cert_verifier.h"
#include "net/cert/signed_certificate_timestamp_and_status.h"
@@ -6444,23 +6444,6 @@ class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
uint32_t num_failures_;
};
-// A CTVerifier that returns net::OK for every certificate.
-class MockCTVerifier : public CTVerifier {
- public:
- MockCTVerifier() {}
- ~MockCTVerifier() override {}
-
- int Verify(X509Certificate* cert,
- const std::string& stapled_ocsp_response,
- const std::string& sct_list_from_tls_extension,
- SignedCertificateTimestampAndStatusList* output_scts,
- const NetLogWithSource& net_log) override {
- return net::OK;
- }
-
- void SetObserver(Observer* observer) override {}
-};
-
// A CTPolicyEnforcer that returns a default CertPolicyCompliance value
// for every certificate.
class MockCTPolicyEnforcer : public CTPolicyEnforcer {
@@ -6508,9 +6491,9 @@ TEST_F(URLRequestTestHTTP, ExpectCTHeader) {
verify_result.is_issued_by_known_root = true;
cert_verifier.AddResultForCert(cert.get(), verify_result, OK);
- // Set up a MockCTVerifier and MockCTPolicyEnforcer to trigger an Expect CT
- // violation.
- MockCTVerifier ct_verifier;
+ // Set up a DoNothingCTVerifier and MockCTPolicyEnforcer to trigger an Expect
+ // CT violation.
+ DoNothingCTVerifier ct_verifier;
MockCTPolicyEnforcer ct_policy_enforcer;
ct_policy_enforcer.set_default_result(
ct::CertPolicyCompliance::CERT_POLICY_NOT_ENOUGH_SCTS);

Powered by Google App Engine
This is Rietveld 408576698