Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: net/cert/multi_log_ct_verifier.h

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Actually optimize for OCSP Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/multi_log_ct_verifier.h
diff --git a/net/cert/multi_log_ct_verifier.h b/net/cert/multi_log_ct_verifier.h
index 05c2c06926469ff9bef9b39e876b8c685ad7f5cc..c4a988787a2404d0d0384186f83b604c97f52be2 100644
--- a/net/cert/multi_log_ct_verifier.h
+++ b/net/cert/multi_log_ct_verifier.h
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/strings/string_piece.h"
#include "net/base/net_export.h"
#include "net/cert/ct_verifier.h"
#include "net/cert/signed_certificate_timestamp.h"
@@ -34,11 +35,11 @@ class NET_EXPORT MultiLogCTVerifier : public CTVerifier {
const std::vector<scoped_refptr<const CTLogVerifier>>& log_verifiers);
// CTVerifier implementation:
- int Verify(X509Certificate* cert,
- const std::string& stapled_ocsp_response,
- const std::string& sct_list_from_tls_extension,
- SignedCertificateTimestampAndStatusList* output_scts,
- const NetLogWithSource& net_log) override;
+ void Verify(X509Certificate* cert,
+ base::StringPiece stapled_ocsp_response,
+ base::StringPiece sct_list_from_tls_extension,
+ SignedCertificateTimestampAndStatusList* output_scts,
+ const NetLogWithSource& net_log) override;
void SetObserver(Observer* observer) override;
@@ -46,7 +47,7 @@ class NET_EXPORT MultiLogCTVerifier : public CTVerifier {
// Verify a list of SCTs from |encoded_sct_list| over |expected_entry|,
// placing the verification results in |result|. The SCTs in the list
eroman 2016/12/27 22:00:41 Same here, can you fix this comment?
// come from |origin| (as will be indicated in the origin field of each SCT).
- bool VerifySCTs(const std::string& encoded_sct_list,
+ void VerifySCTs(base::StringPiece encoded_sct_list,
const ct::LogEntry& expected_entry,
ct::SignedCertificateTimestamp::Origin origin,
X509Certificate* cert,

Powered by Google App Engine
This is Rietveld 408576698