Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: net/cert/ct_signed_certificate_timestamp_log_param.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Actually optimize for OCSP Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_signed_certificate_timestamp_log_param.cc
diff --git a/net/cert/ct_signed_certificate_timestamp_log_param.cc b/net/cert/ct_signed_certificate_timestamp_log_param.cc
index 395c81e0b7b7e8d2269c494da9ab872d91c47cfe..d92f028897facfd9cd185314ed580680bd25dff4 100644
--- a/net/cert/ct_signed_certificate_timestamp_log_param.cc
+++ b/net/cert/ct_signed_certificate_timestamp_log_param.cc
@@ -21,10 +21,9 @@ namespace {
// Base64 encode the given |value| string and put it in |dict| with the
// description |key|.
-void SetBinaryData(
- const char* key,
- const std::string& value,
- base::DictionaryValue* dict) {
+void SetBinaryData(const char* key,
+ base::StringPiece value,
+ base::DictionaryValue* dict) {
std::string b64_value;
base::Base64Encode(value, &b64_value);
@@ -84,15 +83,15 @@ std::unique_ptr<base::Value> NetLogSignedCertificateTimestampCallback(
}
std::unique_ptr<base::Value> NetLogRawSignedCertificateTimestampCallback(
- const std::string* embedded_scts,
- const std::string* sct_list_from_ocsp,
- const std::string* sct_list_from_tls_extension,
+ base::StringPiece embedded_scts,
+ base::StringPiece sct_list_from_ocsp,
+ base::StringPiece sct_list_from_tls_extension,
NetLogCaptureMode capture_mode) {
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- SetBinaryData("embedded_scts", *embedded_scts, dict.get());
- SetBinaryData("scts_from_ocsp_response", *sct_list_from_ocsp, dict.get());
- SetBinaryData("scts_from_tls_extension", *sct_list_from_tls_extension,
+ SetBinaryData("embedded_scts", embedded_scts, dict.get());
+ SetBinaryData("scts_from_ocsp_response", sct_list_from_ocsp, dict.get());
+ SetBinaryData("scts_from_tls_extension", sct_list_from_tls_extension,
dict.get());
return std::move(dict);

Powered by Google App Engine
This is Rietveld 408576698