Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/transport_security_state.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Review feedback round two Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/multi_log_ct_verifier.h ('K') | « net/http/transport_security_state.h ('k') | net/socket/ssl_client_socket_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.cc
diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc
index ce16cca9a1517baf1e3dab049ba4f3a8a924acd6..5f82c2897b51ec403963e9da6674c389f38aff73 100644
--- a/net/http/transport_security_state.cc
+++ b/net/http/transport_security_state.cc
@@ -687,7 +687,7 @@ std::string SerializeExpectStapleRevocationStatus(
bool SerializeExpectStapleReport(const HostPortPair& host_port_pair,
const SSLInfo& ssl_info,
- const std::string& ocsp_response,
+ base::StringPiece ocsp_response,
std::string* out_serialized_report) {
DCHECK(ssl_info.is_issued_by_known_root);
base::DictionaryValue report;
@@ -794,7 +794,7 @@ TransportSecurityState::PKPStatus TransportSecurityState::CheckPublicKeyPins(
void TransportSecurityState::CheckExpectStaple(
const HostPortPair& host_port_pair,
const SSLInfo& ssl_info,
- const std::string& ocsp_response) {
+ base::StringPiece ocsp_response) {
DCHECK(CalledOnValidThread());
if (!enable_static_expect_staple_ || !report_sender_ ||
!ssl_info.is_issued_by_known_root) {
« net/cert/multi_log_ct_verifier.h ('K') | « net/http/transport_security_state.h ('k') | net/socket/ssl_client_socket_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698