Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: net/cert/ct_serialization.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Review feedback round two Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_serialization.cc
diff --git a/net/cert/ct_serialization.cc b/net/cert/ct_serialization.cc
index 60d9426342320435886b275969cb2b5f97641563..64a6ff5c5d097a0b77d2ced8ec4640ab87049461 100644
--- a/net/cert/ct_serialization.cc
+++ b/net/cert/ct_serialization.cc
@@ -383,15 +383,15 @@ void EncodeTreeHeadSignature(const SignedTreeHead& signed_tree_head,
output);
}
-bool DecodeSCTList(base::StringPiece* input,
+bool DecodeSCTList(base::StringPiece input,
std::vector<base::StringPiece>* output) {
std::vector<base::StringPiece> result;
- if (!ReadList(kSCTListLengthBytes, kSerializedSCTLengthBytes,
- input, &result)) {
+ if (!ReadList(kSCTListLengthBytes, kSerializedSCTLengthBytes, &input,
+ &result)) {
return false;
}
- if (!input->empty() || result.empty())
+ if (!input.empty() || result.empty())
return false;
output->swap(result);
return true;

Powered by Google App Engine
This is Rietveld 408576698