Optimize CT & OCSP handling code

net/cert/ct_serialization.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_serialization.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 365 matching lines @@
                              std::string* output) {
   WriteUint(kVersionLength, signed_tree_head.version, output);
   WriteUint(kSignatureTypeLength, TREE_HASH, output);
   WriteTimeSinceEpoch(signed_tree_head.timestamp, output);
   WriteUint(kTreeSizeLength, signed_tree_head.tree_size, output);
   WriteEncodedBytes(
       base::StringPiece(signed_tree_head.sha256_root_hash, kSthRootHashLength),
       output);
 }
 
-bool DecodeSCTList(base::StringPiece* input,
+bool DecodeSCTList(base::StringPiece input,
                    std::vector<base::StringPiece>* output) {
   std::vector<base::StringPiece> result;
-  if (!ReadList(kSCTListLengthBytes, kSerializedSCTLengthBytes,
-                input, &result)) {
+  if (!ReadList(kSCTListLengthBytes, kSerializedSCTLengthBytes, &input,
+                &result)) {
     return false;
   }
 
-  if (!input->empty() || result.empty())
+  if (!input.empty() || result.empty())
     return false;
   output->swap(result);
   return true;
 }
 
 bool DecodeSignedCertificateTimestamp(
     base::StringPiece* input,
     scoped_refptr<SignedCertificateTimestamp>* output) {
   scoped_refptr<SignedCertificateTimestamp> result(
       new SignedCertificateTimestamp());
@@ skipping 24 matching lines @@
 bool EncodeSCTListForTesting(const base::StringPiece& sct,
                              std::string* output) {
   std::string encoded_sct;
   return WriteVariableBytes(kSerializedSCTLengthBytes, sct, &encoded_sct) &&
          WriteVariableBytes(kSCTListLengthBytes, encoded_sct, output);
 }
 
 }  // namespace ct
 
 }  // namespace net