Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: net/cert/ct_objects_extractor_unittest.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Review feedback round two Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/ct_objects_extractor.h" 5 #include "net/cert/ct_objects_extractor.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "net/cert/ct_log_verifier.h" 8 #include "net/cert/ct_log_verifier.h"
9 #include "net/cert/ct_serialization.h" 9 #include "net/cert/ct_serialization.h"
10 #include "net/cert/signed_certificate_timestamp.h" 10 #include "net/cert/signed_certificate_timestamp.h"
(...skipping 26 matching lines...) Expand all
37 } 37 }
38 38
39 void ExtractEmbeddedSCT(scoped_refptr<X509Certificate> cert, 39 void ExtractEmbeddedSCT(scoped_refptr<X509Certificate> cert,
40 scoped_refptr<SignedCertificateTimestamp>* sct) { 40 scoped_refptr<SignedCertificateTimestamp>* sct) {
41 std::string sct_list; 41 std::string sct_list;
42 EXPECT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list)); 42 EXPECT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
43 43
44 std::vector<base::StringPiece> parsed_scts; 44 std::vector<base::StringPiece> parsed_scts;
45 base::StringPiece sct_list_sp(sct_list); 45 base::StringPiece sct_list_sp(sct_list);
46 // Make sure the SCT list can be decoded properly 46 // Make sure the SCT list can be decoded properly
47 EXPECT_TRUE(DecodeSCTList(&sct_list_sp, &parsed_scts)); 47 EXPECT_TRUE(DecodeSCTList(sct_list_sp, &parsed_scts));
48
49 EXPECT_TRUE(DecodeSignedCertificateTimestamp(&parsed_scts[0], sct)); 48 EXPECT_TRUE(DecodeSignedCertificateTimestamp(&parsed_scts[0], sct));
50 } 49 }
51 50
52 protected: 51 protected:
53 CertificateList precert_chain_; 52 CertificateList precert_chain_;
54 scoped_refptr<X509Certificate> test_cert_; 53 scoped_refptr<X509Certificate> test_cert_;
55 scoped_refptr<const CTLogVerifier> log_; 54 scoped_refptr<const CTLogVerifier> log_;
56 }; 55 };
57 56
58 // Test that an SCT can be extracted and the extracted SCT contains the 57 // Test that an SCT can be extracted and the extracted SCT contains the
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 std::string extracted_sct_list; 172 std::string extracted_sct_list;
174 // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|. 173 // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|.
175 EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse( 174 EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
176 test_cert_->os_cert_handle(), subject_cert->serial_number(), 175 test_cert_->os_cert_handle(), subject_cert->serial_number(),
177 ocsp_response, &extracted_sct_list)); 176 ocsp_response, &extracted_sct_list));
178 } 177 }
179 178
180 } // namespace ct 179 } // namespace ct
181 180
182 } // namespace net 181 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698