Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: src/isolate.cc

Issue 2604483005: [isolate] remove redundant return (Closed)
Patch Set: add comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 9cbabef01d9859a8be2e0d3935aab0f21140ec7e..36b3b34e6ff9a0ca5fd56b775d81ed661e73f804 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1820,6 +1820,7 @@ bool PromiseHandlerCheck(Isolate* isolate, Handle<JSReceiver> handler,
// - PromiseIdResolveHandler forwarding to the output of .then
// - Promise.all/Promise.race forwarding to a throwaway Promise, which
// has a dependency edge to the generated outer Promise.
+ // Otherwise, this is a real reject handler for the Promise.
Handle<Symbol> key = isolate->factory()->promise_forwarding_handler_symbol();
Handle<Object> forwarding_handler = JSReceiver::GetDataProperty(handler, key);
if (forwarding_handler->IsUndefined(isolate)) {
@@ -1836,9 +1837,6 @@ bool PromiseHandlerCheck(Isolate* isolate, Handle<JSReceiver> handler,
return InternalPromiseHasUserDefinedRejectHandler(
isolate, Handle<JSPromise>::cast(deferred_promise_obj));
-
- // Otherwise, this is a real reject handler for the Promise
- return true;
}
bool InternalPromiseHasUserDefinedRejectHandler(Isolate* isolate,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698