[promises] Move PromiseHasUserDefinedRejectHandler to c++

src/runtime/runtime-promise.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "src/runtime/runtime-utils.h"
 
 #include "src/debug/debug.h"
 #include "src/elements.h"
 #include "src/promise-utils.h"
 
 namespace v8 {
@@ skipping 261 matching lines @@
   if (reject_reactions->IsJSObject()) {
     return *reject_reactions;
   }
 
   DCHECK(reject_reactions->IsFixedArray());
   return *isolate->factory()->NewJSArrayWithElements(
       Handle<FixedArray>::cast(reject_reactions));
 }
 
 RUNTIME_FUNCTION(Runtime_PromiseMarkAsHandled) {
-  HandleScope scope(isolate);
+  SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0);

[adamk, 2016/12/27 17:44:58]

When using SealHandleScope you don't want to create handles, so this should be

CONVERT_ARG_CHECKED

instead

 
   promise->set_has_handler(true);
   return isolate->heap()->undefined_value();
 }
 
+RUNTIME_FUNCTION(Runtime_PromiseMarkHandledHint) {
+  SealHandleScope shs(isolate);
+  DCHECK(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0);

[adamk, 2016/12/27 17:44:58]

Same down here.

+
+  promise->set_handled_hint(true);
+  return isolate->heap()->undefined_value();
+}
+
 RUNTIME_FUNCTION(Runtime_PromiseHookInit) {
   HandleScope scope(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0);
   CONVERT_ARG_HANDLE_CHECKED(Object, parent, 1);
   isolate->RunPromiseHook(PromiseHookType::kInit, promise, parent);
   return isolate->heap()->undefined_value();
 }
 
 RUNTIME_FUNCTION(Runtime_PromiseHookResolve) {
@@ skipping 18 matching lines @@
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());
   CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0);
   isolate->RunPromiseHook(PromiseHookType::kAfter, promise,
                           isolate->factory()->undefined_value());
   return isolate->heap()->undefined_value();
 }
 
 }  // namespace internal
 }  // namespace v8