dart2js kernel: do less enqueuing.

dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating the constant in code will not hit this issue.

This makes the compiler do work for the same set of elements that were included during resolution. Running all language tests with --dart2js-batch is now 2.5 min (down from 8 min)

BUG=
R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c10363bd70b9ae0e45a7339ea17d7816203624a

[Siggi Cherem (dart-lang), 2016-12-22 22:18:53]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-12-22 22:19:20]

Description was changed from

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer.

BUG=
==========

to

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants.

BUG=
==========

[Siggi Cherem (dart-lang), 2016-12-22 22:19:53]

Description was changed from

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants.

BUG=
==========

to

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating
the constant in code will not hit this issue.

BUG=
==========

[Siggi Cherem (dart-lang), 2016-12-23 00:22:51]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-12-23 00:25:28]

Description was changed from

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating
the constant in code will not hit this issue.

BUG=
==========

to

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating
the constant in code will not hit this issue.

This makes the compiler do work for the same set of elements that were included
during resolution. Running all language tests with --dart2js-batch is now 2.5
min (down from 8 min)

BUG=
==========

[Siggi Cherem (dart-lang), 2016-12-23 00:25:45]

sigmund@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2016-12-23 00:37:49]

lgtm

\o/

[Siggi Cherem (dart-lang), 2016-12-27 22:51:39]

Patchset #2 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2016-12-28 15:35:26]

thanks!

After testing this in host-checked mode, I realized I needed one more fix to
support malformed elements as well. With that, we have no regression on test
coverage, in fact we get 37 new tests passing because we don't enqueue
unnecessary stuff.

Malformed types are interesting: we don't compute their impact, but we do create
an IR element for them (which will throw at runtime). We might want to change it
in the future to produce a special world-impact for them indicating that they
have an error.

[Siggi Cherem (dart-lang), 2016-12-28 15:36:29]

Description was changed from

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating
the constant in code will not hit this issue.

This makes the compiler do work for the same set of elements that were included
during resolution. Running all language tests with --dart2js-batch is now 2.5
min (down from 8 min)

BUG=
==========

to

==========
dart2js kernel: do less enqueuing.

Convert to kernel only classes and elements that have been resolved. For
anything else, pretend the member doesn't exist.

One exception: fields are added because an unused field might still be stored in
an initializer. This appears to only occur with constants in metadata. Creating
the constant in code will not hit this issue.

This makes the compiler do work for the same set of elements that were included
during resolution. Running all language tests with --dart2js-batch is now 2.5
min (down from 8 min)

BUG=
R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c10363bd70b9ae0e45a7339ea17d7816203624a
==========

[Siggi Cherem (dart-lang), 2016-12-28 15:36:31]

Committed patchset #2 (id:80001) manually as
9c10363bd70b9ae0e45a7339ea17d7816203624a (presubmit successful).