Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2604453003: Show Form-Not-Secure warning on page load (Closed)
Patch Set: meacer, jochen comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 0153ac5b4545b9f82c35e1cd5afe4ab3646c27f8..88be1dece93798eb88c848a4832093e0457f40c2 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -886,6 +886,16 @@ bool PasswordAutofillAgent::ShowSuggestions(
element.isPasswordField());
}
+void PasswordAutofillAgent::ShowNotSecureWarning(
+ const blink::WebInputElement& element) {
+ FormData form;
+ FormFieldData field;
+ form_util::FindFormAndFieldForFormControlElement(element, &form, &field);
+ GetPasswordManagerDriver()->ShowNotSecureWarning(
+ field.text_direction,
+ render_frame()->GetRenderView()->ElementBoundsInWindow(element));
+}
+
bool PasswordAutofillAgent::OriginCanAccessPasswordManager(
const blink::WebSecurityOrigin& origin) {
return origin.canAccessPasswordManager();
@@ -1249,12 +1259,15 @@ void PasswordAutofillAgent::FillPasswordForm(
element.isPasswordField()
? element
: web_input_to_password_info_[element].password_field;
- FillFormOnPasswordReceived(
- form_data, username_element, password_element,
- &field_value_and_properties_map_,
- base::Bind(&PasswordValueGatekeeper::RegisterElement,
- base::Unretained(&gatekeeper_)),
- logger.get());
+ if (FillFormOnPasswordReceived(
+ form_data, username_element, password_element,
+ &field_value_and_properties_map_,
+ base::Bind(&PasswordValueGatekeeper::RegisterElement,
+ base::Unretained(&gatekeeper_)),
+ logger.get())) {
+ if (form_data.show_form_not_secure_warning_on_autofill)
+ autofill_agent_->ShowNotSecureWarning(username_element);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698