(Mac)Views: Widgets focus first View in traversal order if initial focus fails.

ui/views/window/dialog_delegate.cc

Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index 333adf9da1840b1f7f8f9f87973268d4f6694499..24a0c7cd1efd63fb0cf8c50b3c2970e0bded187e 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -163,8 +163,11 @@ bool DialogDelegate::IsDialogButtonEnabled(ui::DialogButton button) const {
 }
 
 View* DialogDelegate::GetInitiallyFocusedView() {
-  // Focus the default button if any.
   const DialogClientView* dcv = GetDialogClientView();
+  if (!dcv->GetFocusManager()->keyboard_accessible())

[karandeepb, 2016/12/30 21:16:04]

null-check the focus manager? 

Did you test this on other platforms? keyboard accessibility is off/false on all
platforms except Mac. Hence won't this always return NULL on say Windows? 

We can #ifdef OS_MACOSX this, but I am not sure if this is the correct way to
solve this. (doesn't look generic enough). Another option may be to do something
more sensible in Widget::SetInitialFocus when the initially-focused-view
retrieved can't take focus. For example, what does FocusManager::AdvanceFocus
do, if the focus manager has no focused view?

[Patti Lor, 2017/01/03 03:48:26]

Oops, that's a mistake. I originally had the #ifdefs around this hunk but
removed them for whatever reason. Your suggestion sounds reasonable though -
looks like FocusManager::AdvanceFocus() works when focus is cleared. I've
changed the fix to be in Widget::SetInitialFocus() instead.

[karandeepb, 2017/01/04 00:12:33]

Yeah this seems reasonable to me as well, though owners might have a different
take.

+    return NULL;
+
+  // Focus the default button if any.
   int default_button = GetDefaultDialogButton();
   if (default_button == ui::DIALOG_BUTTON_NONE)
     return NULL;