Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: ui/views/widget/widget.cc

Issue 2604303002: (Mac)Views: Widgets focus first View in traversal order if initial focus fails. (Closed)
Patch Set: Review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.cc
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index 08578add8f534fe637481183fd005dbc34a58a1c..8b062753e23765729eb07cb7ac267a9ff10fe818 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -1303,18 +1303,24 @@ const Widget* Widget::AsWidget() const {
}
bool Widget::SetInitialFocus(ui::WindowShowState show_state) {
+ FocusManager* focus_manager = GetFocusManager();
View* v = widget_delegate_->GetInitiallyFocusedView();
if (!focus_on_creation_ || show_state == ui::SHOW_STATE_INACTIVE ||
show_state == ui::SHOW_STATE_MINIMIZED) {
// If not focusing the window now, tell the focus manager which view to
// focus when the window is restored.
- if (v && focus_manager_.get())
- focus_manager_->SetStoredFocusView(v);
+ if (v && focus_manager)
+ focus_manager->SetStoredFocusView(v);
return true;
}
- if (v)
+ if (v) {
v->RequestFocus();
- return !!v;
+ // If the request for focus was unsuccessful, fall back to using the first
+ // focusable View instead.
+ if (focus_manager && focus_manager->GetFocusedView() == nullptr)
+ focus_manager->AdvanceFocus(false);
+ }
+ return !!focus_manager->GetFocusedView();
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « no previous file | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698