(Mac)Views: Widgets focus first View in traversal order if initial focus fails.

ui/views/widget/widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/widget.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 1294 matching lines @@
 bool Widget::SetInitialFocus(ui::WindowShowState show_state) {
   View* v = widget_delegate_->GetInitiallyFocusedView();
   if (!focus_on_creation_ || show_state == ui::SHOW_STATE_INACTIVE ||
       show_state == ui::SHOW_STATE_MINIMIZED) {
     // If not focusing the window now, tell the focus manager which view to
     // focus when the window is restored.
     if (v && focus_manager_.get())
       focus_manager_->SetStoredFocusView(v);
     return true;
   }
-  if (v)
+  if (v) {
     v->RequestFocus();

[tapted, 2017/01/04 03:59:38]

This is a bit inconsistent. View::RequestFocus() uses Widget::GetFocusManager()
which may return something other than |focus_manager_|. Very little in Widget
uses focus_manager_ directly - and it all has a comment. I think we want
something at the top of the function like

FocusManager* focus_manager = GetFocusManager()
if (!focus_manager)
  return;

the use on line 1311-2 can be updated too.

[Patti Lor, 2017/01/06 06:15:09]

Done.

+    // If the request for focus was unsuccessful, fall back to using the first
+    // focusable View instead.
+    if (focus_manager_ && v != focus_manager_->GetFocusedView())

[tapted, 2017/01/04 03:59:38]

Is it enough just to call focus_manager->AdvanceFocusIfNecessary()?

[Patti Lor, 2017/01/06 06:15:09]

No - AdvanceFocusIfNecessary is only meant to make sure no unfocusable views
have focus. When the focus is cleared, that's considered a valid state and it
doesn't do anything.

+      focus_manager_->AdvanceFocus(false);
+  }
   return !!v;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Widget, ui::EventSource implementation:
 ui::EventProcessor* Widget::GetEventProcessor() {
   return root_view_.get();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 163 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // internal::NativeWidgetPrivate, NativeWidget implementation:
 
 internal::NativeWidgetPrivate* NativeWidgetPrivate::AsNativeWidgetPrivate() {
   return this;
 }
 
 }  // namespace internal
 }  // namespace views