Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: src/builtins/builtins-promise.h

Issue 2604273003: [csa] Refactor promises API (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-promise.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-promise.h
diff --git a/src/builtins/builtins-promise.h b/src/builtins/builtins-promise.h
index 8615f967949b59a6b2fbb9f502e77f9517187162..f3d1e9544488162d89cb5f47671525fe695201d8 100644
--- a/src/builtins/builtins-promise.h
+++ b/src/builtins/builtins-promise.h
@@ -16,7 +16,11 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
explicit PromiseBuiltinsAssembler(CodeAssemblerState* state)
: CodeStubAssembler(state) {}
- Node* AllocateAndInitPromise(Node* context, Node* parent);
+ // These are just wrapper functions over the CSA counterparts and
+ // call out to the init promise hook.
adamk 2017/01/03 18:23:06 This is really a question for caitp, I think, but
caitp 2017/01/03 18:32:05 I'm not sure if there are any situations where we'
+ Node* AllocateAndInitJSPromise(Node* context, Node* parent);
+ Node* AllocateAndSetJSPromise(Node* context, Node* status, Node* result,
+ Node* parent);
Node* ThrowIfNotJSReceiver(Node* context, Node* value,
MessageTemplate::Template msg_template);
« no previous file with comments | « no previous file | src/builtins/builtins-promise.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698