[csa] Refactor promises API

src/code-stub-assembler.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "src/code-stub-assembler.h"
 #include "src/code-factory.h"
 #include "src/frames-inl.h"
 #include "src/frames.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 8297 matching lines @@
                                  shared_info);
   StoreObjectFieldNoWriteBarrier(fun, JSFunction::kContextOffset, context);
   StoreObjectFieldNoWriteBarrier(fun, JSFunction::kCodeEntryOffset, code_entry,
                                  MachineType::PointerRepresentation());
   StoreObjectFieldRoot(fun, JSFunction::kNextFunctionLinkOffset,
                        Heap::kUndefinedValueRootIndex);
 
   return fun;
 }
 
-Node* CodeStubAssembler::AllocateJSPromise(Node* context) {
+Node* CodeStubAssembler::AllocateAndInitJSPromise(Node* context) {
   Node* const native_context = LoadNativeContext(context);
   Node* const promise_fun =
       LoadContextElement(native_context, Context::PROMISE_FUNCTION_INDEX);
   Node* const initial_map =
       LoadObjectField(promise_fun, JSFunction::kPrototypeOrInitialMapOffset);
-  Node* const instance = AllocateJSObjectFromMap(initial_map);
+  Node* const promise = AllocateJSObjectFromMap(initial_map);
+  StoreObjectFieldNoWriteBarrier(promise, JSPromise::kStatusOffset,
+                                 SmiConstant(v8::Promise::kPending));
+  StoreObjectFieldNoWriteBarrier(promise, JSPromise::kFlagsOffset,
+                                 SmiConstant(0));
 
-  return instance;
+  return promise;
 }
 
-void CodeStubAssembler::PromiseInit(Node* promise) {
+Node* CodeStubAssembler::AllocateAndSetJSPromise(Node* context, Node* status,
+                                                 Node* result) {
+  Node* const native_context = LoadNativeContext(context);
+  Node* const promise_fun =
+      LoadContextElement(native_context, Context::PROMISE_FUNCTION_INDEX);
+  Node* const initial_map =
+      LoadObjectField(promise_fun, JSFunction::kPrototypeOrInitialMapOffset);
+  Node* const promise = AllocateJSObjectFromMap(initial_map);
+
+  CSA_ASSERT(this, TaggedIsSmi(status));
+
+  StoreObjectFieldNoWriteBarrier(promise, JSPromise::kStatusOffset, status);
+  StoreObjectFieldNoWriteBarrier(promise, JSPromise::kResultOffset, result);
+  StoreObjectFieldNoWriteBarrier(promise, JSPromise::kFlagsOffset,
+                                 SmiConstant(0));
+
+  return promise;
+}
+
+void CodeStubAssembler::JSPromiseInit(Node* promise) {
   StoreObjectField(promise, JSPromise::kStatusOffset,
                    SmiConstant(v8::Promise::kPending));
   StoreObjectField(promise, JSPromise::kFlagsOffset, SmiConstant(0));
 }
 
-void CodeStubAssembler::PromiseSet(Node* promise, Node* status, Node* result) {
-  CSA_ASSERT(this, TaggedIsSmi(status));
-  StoreObjectField(promise, JSPromise::kStatusOffset, status);
-  StoreObjectField(promise, JSPromise::kResultOffset, result);
-  StoreObjectField(promise, JSPromise::kFlagsOffset, SmiConstant(0));
-}
-
 Node* CodeStubAssembler::AllocatePromiseReactionJobInfo(
     Node* promise, Node* value, Node* tasks, Node* deferred_promise,
     Node* deferred_on_resolve, Node* deferred_on_reject, Node* context) {
   Node* const result = Allocate(PromiseReactionJobInfo::kSize);
   StoreMapNoWriteBarrier(result, Heap::kPromiseReactionJobInfoMapRootIndex);
   StoreObjectFieldNoWriteBarrier(result, PromiseReactionJobInfo::kValueOffset,
                                  value);
   StoreObjectFieldNoWriteBarrier(result, PromiseReactionJobInfo::kPromiseOffset,
                                  promise);
   StoreObjectFieldNoWriteBarrier(result, PromiseReactionJobInfo::kTasksOffset,
@@ skipping 10 matching lines @@
                        Heap::kUndefinedValueRootIndex);
   StoreObjectFieldRoot(result, PromiseReactionJobInfo::kDebugNameOffset,
                        Heap::kUndefinedValueRootIndex);
   StoreObjectFieldNoWriteBarrier(result, PromiseReactionJobInfo::kContextOffset,
                                  context);
   return result;
 }
 
 }  // namespace internal
 }  // namespace v8