Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: components/omnibox/browser/autocomplete_classifier.cc

Issue 2604243002: Add Physical Web omnibox support for Android (Closed)
Patch Set: Remove comments change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/autocomplete_classifier.cc
diff --git a/components/omnibox/browser/autocomplete_classifier.cc b/components/omnibox/browser/autocomplete_classifier.cc
index 4e50bbfd9fe325f0d8d7edcc491d3326edce153e..c6e81cfe9ae2c0dde0b5d51f6d785a8c43973ed0 100644
--- a/components/omnibox/browser/autocomplete_classifier.cc
+++ b/components/omnibox/browser/autocomplete_classifier.cc
@@ -17,8 +17,11 @@
// static
const int AutocompleteClassifier::kDefaultOmniboxProviders =
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
- // Custom search engines cannot be used on mobile..
+#if defined(OS_ANDROID) || defined(OS_IOS)
+ // The Physical Web currently is only implemented on mobile devices.
+ AutocompleteProvider::TYPE_PHYSICAL_WEB |
+#else
+ // Custom search engines cannot be used on mobile.
AutocompleteProvider::TYPE_KEYWORD |
#endif
#if !defined(OS_IOS)
@@ -29,8 +32,6 @@ const int AutocompleteClassifier::kDefaultOmniboxProviders =
#else
// "URL from clipboard" can only be used on iOS.
AutocompleteProvider::TYPE_CLIPBOARD_URL |
- // Physical Web omnibox results are only implemented on iOS.
- AutocompleteProvider::TYPE_PHYSICAL_WEB |
#endif
AutocompleteProvider::TYPE_BOOKMARK |
AutocompleteProvider::TYPE_HISTORY_QUICK |
« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698