Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/omnibox/browser/autocomplete_classifier.cc

Issue 2604243002: Add Physical Web omnibox support for Android (Closed)
Patch Set: Remove new constant Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/autocomplete_classifier.cc
diff --git a/components/omnibox/browser/autocomplete_classifier.cc b/components/omnibox/browser/autocomplete_classifier.cc
index 4e50bbfd9fe325f0d8d7edcc491d3326edce153e..fcb870baa3cd73828f4dcf6db3cc6f3822fd1700 100644
--- a/components/omnibox/browser/autocomplete_classifier.cc
+++ b/components/omnibox/browser/autocomplete_classifier.cc
@@ -17,7 +17,9 @@
// static
const int AutocompleteClassifier::kDefaultOmniboxProviders =
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#if defined(OS_ANDROID) || defined(OS_IOS)
+ AutocompleteProvider::TYPE_PHYSICAL_WEB |
Mark P 2017/01/05 19:52:31 Please comment, e.g., is this here because it's no
cco3 2017/01/05 20:24:05 Done.
+#else
// Custom search engines cannot be used on mobile..
Mark P 2017/01/05 19:52:31 nit: please remove the extra period while you're h
cco3 2017/01/05 20:24:05 Done.
AutocompleteProvider::TYPE_KEYWORD |
#endif
@@ -29,8 +31,6 @@ const int AutocompleteClassifier::kDefaultOmniboxProviders =
#else
// "URL from clipboard" can only be used on iOS.
AutocompleteProvider::TYPE_CLIPBOARD_URL |
- // Physical Web omnibox results are only implemented on iOS.
- AutocompleteProvider::TYPE_PHYSICAL_WEB |
#endif
AutocompleteProvider::TYPE_BOOKMARK |
AutocompleteProvider::TYPE_HISTORY_QUICK |
« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | content/public/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698