Relocate suspended generator activations when enabling debug mode

Relocate suspended generator activations when enabling debug mode

R=yangguo@chromium.org
BUG=v8:3289
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=21141

[wingo, 2014-04-29 15:45:23]

This is a first draft and is missing tests.  Is re-using the active frame
relocation logic a terrible thing or no?  (Yes it's terrible, I guess.  Is it
still the right thing?)

[wingo, 2014-04-30 11:47:25]

Fixed bugs in first patchset and added tests.  The tests fail on master.  PTAL.

[Yang, 2014-05-05 09:40:15]

Nice refactoring. Looking good so far, but I have one comment.
Also sorry for the delay. Had vacation/holidays.

https://codereview.chromium.org/260423002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/260423002/diff/20001/src/debug.cc#newcode2104
src/debug.cc:2104: CollectSuspendedGenerators(&suspended_generators);
Do we really need to iterate the heap twice? Can this be folded into the heap
iteration below where we look for JSFunctions?

[wingo, 2014-05-05 11:08:43]

https://codereview.chromium.org/260423002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/260423002/diff/20001/src/debug.cc#newcode2104
src/debug.cc:2104: CollectSuspendedGenerators(&suspended_generators);
On 2014/05/05 09:40:15, Yang wrote:
> Do we really need to iterate the heap twice? Can this be folded into the heap
> iteration below where we look for JSFunctions?

Hum, I think you are right.  The double iteration was an artifact of an earlier
patch.  Will post an update, thanks for the review :)

[wingo, 2014-05-05 11:21:18]

Updated patch to iterate heap only once.  PTAL :)

[Yang, 2014-05-05 11:33:12]

On 2014/05/05 11:21:18, wingo wrote:
> Updated patch to iterate heap only once.  PTAL :)

lgtm.

[wingo, 2014-05-05 12:57:23]

Committed patchset #3 manually as r21141 (presubmit successful).

[wingo, 2014-05-05 13:24:58]

A revert of this CL has been created in
https://codereview.chromium.org/265303002/ by wingo@igalia.com.

The reason for reverting is: Rolling out for build breakage ('Tree is closed
(Automatic: "compile" on "V8 Win64" from 21141: wingo@igalia.com)').