third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py - Issue 2604223002: Add TODO for confusing code in layout_test_runner_unittest.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

Issue 2604223002: Add TODO for confusing code in layout_test_runner_unittest.py. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

index 529a23baf2414de94696c4d84c330cdce4fd240a..00d646466d5ca7f0a1537d834738c5521b4aff10 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

@@ -79,6 +79,8 @@ class LockCheckingRunner(LayoutTestRunner):

self._should_have_http_lock = http_lock

def handle_finished_list(self, source, list_name, num_tests, elapsed_time):

+ # TODO(qyearsley): This is never called; it should be fixed or removed.

+ self._tester.fail('This is never called')

if not self._finished_list_called:

self._tester.assertEqual(list_name, 'locked_tests')

self._tester.assertTrue(self._remaining_locked_shards)

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py ('k') | no next file » | no next file with comments »