Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260413002: Enable VK overscroll by default. (Closed)

Created:
6 years, 7 months ago by kevers
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Enable VK overscroll by default. BUG=242933 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M ui/keyboard/keyboard_util.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kevers
Biao, Can you please take a look at this CL?
6 years, 7 months ago (2014-04-29 15:13:04 UTC) #1
bshe
lgtm
6 years, 7 months ago (2014-04-29 15:16:02 UTC) #2
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 7 months ago (2014-04-29 15:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/260413002/1
6 years, 7 months ago (2014-04-29 15:16:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:30:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:30:23 UTC) #6
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 7 months ago (2014-04-29 21:42:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/260413002/1
6 years, 7 months ago (2014-04-29 21:45:02 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:23:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:23:48 UTC) #10
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 7 months ago (2014-04-29 23:15:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/260413002/1
6 years, 7 months ago (2014-04-29 23:17:43 UTC) #12
commit-bot: I haz the power
Change committed as 267115
6 years, 7 months ago (2014-04-30 07:20:50 UTC) #13
Nikita (slow)
6 years, 7 months ago (2014-04-30 09:53:29 UTC) #14
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/253303003/ by nkostylev@chromium.org.

The reason for reverting is: Speculative revert, suspecting that it breaks
ash_unittests.

http://goo.gl/ZxoISj
http://goo.gl/RlD70H.

Powered by Google App Engine
This is Rietveld 408576698