Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: mojo/public/cpp/bindings/tests/wtf_types_unittest.cc

Issue 2604113002: Remove mojo::WTFArray. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc b/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
index f10947f57fe239fdce2c80d666575427790615f3..f299ae469a0ec8a9a29fe7850feecc2826b00ab5 100644
--- a/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
@@ -106,29 +106,6 @@ void ExpectStringMap(
} // namespace
-TEST_F(WTFTypesTest, Serialization_WTFArrayToWTFArray) {
- using MojomType = ArrayDataView<StringDataView>;
-
- WTFArray<WTF::String> strs = ConstructStringArray();
- auto cloned_strs = strs.Clone();
-
- mojo::internal::SerializationContext context;
- size_t size =
- mojo::internal::PrepareToSerialize<MojomType>(cloned_strs, &context);
-
- mojo::internal::FixedBufferForTesting buf(size);
- typename mojo::internal::MojomTypeTraits<MojomType>::Data* data;
- mojo::internal::ContainerValidateParams validate_params(
- 0, true, new mojo::internal::ContainerValidateParams(0, false, nullptr));
- mojo::internal::Serialize<MojomType>(cloned_strs, &buf, &data,
- &validate_params, &context);
-
- WTFArray<WTF::String> strs2;
- mojo::internal::Deserialize<MojomType>(data, &strs2, &context);
-
- EXPECT_TRUE(strs.Equals(strs2));
-}
-
TEST_F(WTFTypesTest, Serialization_WTFVectorToWTFVector) {
using MojomType = ArrayDataView<StringDataView>;
@@ -152,31 +129,6 @@ TEST_F(WTFTypesTest, Serialization_WTFVectorToWTFVector) {
EXPECT_EQ(strs, strs2);
}
-TEST_F(WTFTypesTest, Serialization_WTFArrayToMojoArray) {
- using MojomType = ArrayDataView<StringDataView>;
-
- WTFArray<WTF::String> strs = ConstructStringArray();
-
- mojo::internal::SerializationContext context;
- size_t size = mojo::internal::PrepareToSerialize<MojomType>(strs, &context);
-
- mojo::internal::FixedBufferForTesting buf(size);
- typename mojo::internal::MojomTypeTraits<MojomType>::Data* data;
- mojo::internal::ContainerValidateParams validate_params(
- 0, true, new mojo::internal::ContainerValidateParams(0, false, nullptr));
- mojo::internal::Serialize<MojomType>(strs, &buf, &data, &validate_params,
- &context);
-
- Array<std::string> strs2;
- mojo::internal::Deserialize<MojomType>(data, &strs2, &context);
-
- ASSERT_EQ(4u, strs2.size());
- EXPECT_TRUE(strs2[0].empty());
- EXPECT_TRUE("" == strs2[1]);
- EXPECT_TRUE(kHelloWorld == strs2[2]);
- EXPECT_TRUE(kUTF8HelloWorld == strs2[3]);
-}
-
TEST_F(WTFTypesTest, Serialization_PublicAPI) {
blink::TestWTFStructPtr input(blink::TestWTFStruct::New());
input->str = kHelloWorld;

Powered by Google App Engine
This is Rietveld 408576698