Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2604073002: Apply offset from the correct graphics layer; simplify code for link highlights. (Closed)
Patch Set: none Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 return true; 604 return true;
605 } else { 605 } else {
606 ASSERT(object->isText()); 606 ASSERT(object->isText());
607 } 607 }
608 } 608 }
609 } 609 }
610 return false; 610 return false;
611 } 611 }
612 612
613 void LayoutBoxModelObject::absoluteQuadsForSelf( 613 void LayoutBoxModelObject::absoluteQuadsForSelf(
614 Vector<FloatQuad>& quads) const { 614 Vector<FloatQuad>& quads,
615 MapCoordinatesFlags mode) const {
615 NOTREACHED(); 616 NOTREACHED();
616 } 617 }
617 618
618 void LayoutBoxModelObject::absoluteQuads(Vector<FloatQuad>& quads) const { 619 void LayoutBoxModelObject::absoluteQuads(Vector<FloatQuad>& quads,
619 absoluteQuadsForSelf(quads); 620 MapCoordinatesFlags mode) const {
621 absoluteQuadsForSelf(quads, mode);
620 622
621 // Iterate over continuations, avoiding recursion in case there are 623 // Iterate over continuations, avoiding recursion in case there are
622 // many of them. See crbug.com/653767. 624 // many of them. See crbug.com/653767.
623 for (const LayoutBoxModelObject* continuationObject = this->continuation(); 625 for (const LayoutBoxModelObject* continuationObject = this->continuation();
624 continuationObject; 626 continuationObject;
625 continuationObject = continuationObject->continuation()) { 627 continuationObject = continuationObject->continuation()) {
626 DCHECK(continuationObject->isLayoutInline() || 628 DCHECK(continuationObject->isLayoutInline() ||
627 (continuationObject->isLayoutBlockFlow() && 629 (continuationObject->isLayoutBlockFlow() &&
628 toLayoutBlockFlow(continuationObject) 630 toLayoutBlockFlow(continuationObject)
629 ->isAnonymousBlockContinuation())); 631 ->isAnonymousBlockContinuation()));
630 continuationObject->absoluteQuadsForSelf(quads); 632 continuationObject->absoluteQuadsForSelf(quads, mode);
631 } 633 }
632 } 634 }
633 635
634 void LayoutBoxModelObject::updateFromStyle() { 636 void LayoutBoxModelObject::updateFromStyle() {
635 const ComputedStyle& styleToUse = styleRef(); 637 const ComputedStyle& styleToUse = styleRef();
636 setHasBoxDecorationBackground(styleToUse.hasBoxDecorationBackground()); 638 setHasBoxDecorationBackground(styleToUse.hasBoxDecorationBackground());
637 setInline(styleToUse.isDisplayInlineType()); 639 setInline(styleToUse.isDisplayInlineType());
638 setPositionState(styleToUse.position()); 640 setPositionState(styleToUse.position());
639 setHorizontalWritingMode(styleToUse.isHorizontalWritingMode()); 641 setHorizontalWritingMode(styleToUse.isHorizontalWritingMode());
640 } 642 }
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
1336 if (rootElementStyle->hasBackground()) 1338 if (rootElementStyle->hasBackground())
1337 return false; 1339 return false;
1338 1340
1339 if (node() != document().firstBodyElement()) 1341 if (node() != document().firstBodyElement())
1340 return false; 1342 return false;
1341 1343
1342 return true; 1344 return true;
1343 } 1345 }
1344 1346
1345 } // namespace blink 1347 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h ('k') | third_party/WebKit/Source/core/layout/LayoutFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698