Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2604063002: Log intents received differently if they are internal or external. (Closed)
Patch Set: Fix compile Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 43c254cf9ac7102f94fa36895b4f7866f811910f..a21822cb2281127fec07e374ed177689e46645bb 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -10042,8 +10042,33 @@ should be able to be added at any place in this file.
</action>
<action name="MobileReceivedExternalIntent">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>mariakhomenko@chromium.org</owner>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ A VIEW intent was received by the tabbed mode activity. This will combine
+ intents sent by external application as well as Chrome itself. This does
+ not cover all intent types handled by Chrome. Use
+ MobileTabbedModeViewIntentFromApp and MobileTabbedModeViewIntentFromChrome
+ for a complete picture.
+ </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.App">
+ <owner>mariakhomenko@chromium.org</owner>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ A VIEW intent was received by the tabbed mode activity from an external
+ application.
+ </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.Chrome">
+ <owner>mariakhomenko@chromium.org</owner>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ A VIEW intent was received by the tabbed mode activity from Chrome. This is
+ only recorded for intent types that are also allowed from external apps.
+ </description>
</action>
<action name="MobileRendererCrashed">
@@ -10139,6 +10164,23 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="MobileTabbedModeViewIntentFromApp">
+ <owner>mariakhomenko@chromium.org</owner>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ A VIEW intent was received by the tabbed mode activity from an external
+ application.
+ </description>
+</action>
+
+<action name="MobileTabbedModeViewIntentFromChrome">
+ <owner>mariakhomenko@chromium.org</owner>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ A VIEW intent was received by the tabbed mode activity from Chrome.
+ </description>
+</action>
+
<action name="MobileToolbarBack">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698