Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2604023002: ABANDONED CL: Rewrite also identifiers declared in generated files. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, nasko, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL: This is not needed, even without this we are able to build everything after the great rename. Rewrite also identifiers declared in generated files. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/generated-expected.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/namespaces-expected.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/namespaces-original.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Łukasz Anforowicz
Sharing this CL mostly as an FYI for now - we still don't know which ...
3 years, 11 months ago (2016-12-28 18:03:55 UTC) #1
dcheng
3 years, 11 months ago (2016-12-28 18:23:08 UTC) #3
Do we have a rough idea of how many references to generated code there are from
non-generated code?

Powered by Google App Engine
This is Rietveld 408576698