Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: ios/clean/chrome/browser/ui/tools/tools_coordinator.mm

Issue 2603783002: [Clean Skeleton] Fix menu dismiss and positions. (Closed)
Patch Set: Changed menu sizing. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // ====== New Architecture ===== 5 // ====== New Architecture =====
6 // = This code is only used in the new iOS Chrome architecture. = 6 // = This code is only used in the new iOS Chrome architecture. =
7 // ============================================================================ 7 // ============================================================================
8 8
9 #import "ios/clean/chrome/browser/ui/tools/tools_coordinator.h" 9 #import "ios/clean/chrome/browser/ui/tools/tools_coordinator.h"
10 10
11 #import "ios/clean/chrome/browser/ui/animators/zoom_transition_animator.h" 11 #import "ios/clean/chrome/browser/ui/animators/zoom_transition_animator.h"
12 #import "ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h" 12 #import "ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h"
13 #import "ios/clean/chrome/browser/ui/tools/menu_view_controller.h" 13 #import "ios/clean/chrome/browser/ui/tools/menu_view_controller.h"
14 14
15 #if !defined(__has_feature) || !__has_feature(objc_arc) 15 #if !defined(__has_feature) || !__has_feature(objc_arc)
16 #error "This file requires ARC support." 16 #error "This file requires ARC support."
17 #endif 17 #endif
18 18
19 @interface ToolsCoordinator ()<UIViewControllerTransitioningDelegate> 19 @interface ToolsCoordinator ()<UIViewControllerTransitioningDelegate>
20 @property(nonatomic, strong) MenuViewController* menuViewController; 20 @property(nonatomic, strong) MenuViewController* menuViewController;
21 @end 21 @end
22 22
23 @implementation ToolsCoordinator 23 @implementation ToolsCoordinator
24 @synthesize toolbarCommandHandler = _toolbarCommandHandler;
24 @synthesize menuViewController = _menuViewController; 25 @synthesize menuViewController = _menuViewController;
25 26
26 #pragma mark - BrowserCoordinator 27 #pragma mark - BrowserCoordinator
27 28
28 - (void)start { 29 - (void)start {
29 self.menuViewController = [[MenuViewController alloc] init]; 30 self.menuViewController = [[MenuViewController alloc] init];
30 self.menuViewController.modalPresentationStyle = UIModalPresentationCustom; 31 self.menuViewController.modalPresentationStyle = UIModalPresentationCustom;
31 self.menuViewController.transitioningDelegate = self; 32 self.menuViewController.transitioningDelegate = self;
32 33
33 [self.rootViewController presentViewController:self.menuViewController 34 [self.rootViewController presentViewController:self.menuViewController
(...skipping 26 matching lines...) Expand all
60 } 61 }
61 62
62 - (UIPresentationController*) 63 - (UIPresentationController*)
63 presentationControllerForPresentedViewController:(UIViewController*)presented 64 presentationControllerForPresentedViewController:(UIViewController*)presented
64 presentingViewController:(UIViewController*)presenting 65 presentingViewController:(UIViewController*)presenting
65 sourceViewController:(UIViewController*)source { 66 sourceViewController:(UIViewController*)source {
66 MenuPresentationController* menuPresentation = 67 MenuPresentationController* menuPresentation =
67 [[MenuPresentationController alloc] 68 [[MenuPresentationController alloc]
68 initWithPresentedViewController:presented 69 initWithPresentedViewController:presented
69 presentingViewController:presenting]; 70 presentingViewController:presenting];
71 menuPresentation.toolbarCommandHandler = self.toolbarCommandHandler;
70 return menuPresentation; 72 return menuPresentation;
71 } 73 }
72 74
73 @end 75 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698