Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: content/common/associated_interface_provider_impl.cc

Issue 2603743002: Simplify content::AssociatedInterfaceProviderImpl (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/associated_interface_provider_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/associated_interface_provider_impl.cc
diff --git a/content/common/associated_interface_provider_impl.cc b/content/common/associated_interface_provider_impl.cc
index 454250d1d968c4853fb526e2f52db1ef7d9dc8c0..43421078dd4cd99f17167bb0f9d3fbabd77ad57b 100644
--- a/content/common/associated_interface_provider_impl.cc
+++ b/content/common/associated_interface_provider_impl.cc
@@ -4,20 +4,16 @@
#include "content/common/associated_interface_provider_impl.h"
#include "mojo/public/cpp/bindings/associated_binding.h"
-#include "mojo/public/cpp/bindings/binding.h"
namespace content {
class AssociatedInterfaceProviderImpl::LocalProvider
- : public mojom::RouteProvider,
- mojom::AssociatedInterfaceProvider {
+ : public mojom::AssociatedInterfaceProvider {
public:
explicit LocalProvider(mojom::AssociatedInterfaceProviderAssociatedPtr* proxy)
- : route_provider_binding_(this),
- associated_interface_provider_binding_(this) {
- route_provider_binding_.Bind(mojo::MakeRequest(&route_provider_ptr_));
- route_provider_ptr_->GetRoute(
- 0, mojo::MakeRequest(proxy, route_provider_ptr_.associated_group()));
+ : associated_interface_provider_binding_(this) {
+ associated_interface_provider_binding_.Bind(
+ mojo::MakeRequestForTesting(proxy));
kinuko 2016/12/28 02:47:24 Is this ctor mainly for testing? ...looks like so
leonhsl(Using Gerrit) 2016/12/28 03:03:40 Yeah it's true, this ctor is only used from Associ
}
~LocalProvider() override {}
@@ -29,14 +25,6 @@ class AssociatedInterfaceProviderImpl::LocalProvider
}
private:
- // mojom::RouteProvider:
- void GetRoute(
- int32_t routing_id,
- mojom::AssociatedInterfaceProviderAssociatedRequest request) override {
- DCHECK(request.is_pending());
- associated_interface_provider_binding_.Bind(std::move(request));
- }
-
// mojom::AssociatedInterfaceProvider:
void GetAssociatedInterface(
const std::string& name,
@@ -51,9 +39,6 @@ class AssociatedInterfaceProviderImpl::LocalProvider
base::Callback<void(mojo::ScopedInterfaceEndpointHandle)>>;
BinderMap binders_;
- mojom::RouteProviderPtr route_provider_ptr_;
- mojo::Binding<mojom::RouteProvider> route_provider_binding_;
-
mojo::AssociatedBinding<mojom::AssociatedInterfaceProvider>
associated_interface_provider_binding_;
};
« no previous file with comments | « content/common/associated_interface_provider_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698