Issue 260373002: Revert of [WebsiteSettings] Update permission bubble manager policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260373002: Revert of [WebsiteSettings] Update permission bubble manager policy (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 7 months ago

Reviewers:
Randy Smith (Not in Mondays), markusheintz_, leng, Greg Billock, Paweł Hajdan Jr.

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of [WebsiteSettings] Update permission bubble manager policy (https://codereview.chromium.org/243543003/) Reason for revert: This breaks Linux ASAN, heap use after free: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2360 Original issue's description: > [WebsiteSettings] Update permission bubble manager policy > > This policy is more in accord with the design doc changes. Moves to > showing the dialog upon DOMContentLoaded in source pages, and then > subsequently for user gestures. > > R=leng@chromium.org > BUG=332115, 364159 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266855 TBR=leng@chromium.org,markusheintz@chromium.org,rdsmith@chromium.org,phajdan.jr@chromium.org,gbillock@chromium.org NOTREECHECKS=true NOTRY=true BUG=332115, 364159 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266861

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -35 lines)			Patch
M	chrome/browser/download/download_request_limiter_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager.h	View	5 chunks	+17 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager.cc	View	7 chunks	+44 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of [WebsiteSettings] Update permission bubble manager policy

6 years, 7 months ago (2014-04-29 13:05:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/260373002/1

6 years, 7 months ago (2014-04-29 13:06:02 UTC) #2

Message was sent while issue was closed.

Change committed as 266861