Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11105)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Issue 2603663002: Make IME extensions decide when to show the keyboard. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc b/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
index 2fd3d3f74625a7ff65c66fd7f1dc518d52bc18c6..13c4dae5a215db9343d985e28121a96649ce3420 100644
--- a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
@@ -433,7 +433,12 @@ void ImeMenuTray::ShowKeyboardWithKeyset(const std::string& keyset) {
show_keyboard_ = true;
if (keyboard_controller) {
keyboard_controller->AddObserver(this);
- keyboard_controller->ShowKeyboard(false);
+ // If the keyboard hasn't been loaded yet, it means it's the first time to
+ // show keyboard, OS need to trigger it. Otherwise, make IME extensions
Shu Chen 2016/12/26 02:16:39 // If the keyboard window hasn't been created yet,
Azure Wei 2016/12/26 06:53:30 Done.
+ // decide when to show the keyboard.
+ if (!keyboard_controller->KeyboardHasBeenLoaded()) {
Shu Chen 2016/12/26 02:16:39 s/KeyboardHasBeenLoaded/IsKeyboardWindowCreated/g
Azure Wei 2016/12/26 06:53:30 Done.
+ keyboard_controller->ShowKeyboard(false);
+ }
return;
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698