Make IME extensions decide when to show the keyboard.

ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/ime_menu/ime_menu_tray.h"
 
 #include "ash/common/accessibility_delegate.h"
 #include "ash/common/ash_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
@@ skipping 344 matching lines @@
   tray_notifier->AddIMEObserver(this);
   tray_notifier->AddVirtualKeyboardObserver(this);
 }
 
 ImeMenuTray::~ImeMenuTray() {
   if (bubble_)
     bubble_->bubble_view()->reset_delegate();
   SystemTrayNotifier* tray_notifier = WmShell::Get()->system_tray_notifier();
   tray_notifier->RemoveIMEObserver(this);
   tray_notifier->RemoveVirtualKeyboardObserver(this);
+  keyboard::KeyboardController* keyboard_controller =
+      keyboard::KeyboardController::GetInstance();
+  if (keyboard_controller) {
+    keyboard_controller->RemoveObserver(this);
+  }
 }
 
 void ImeMenuTray::ShowImeMenuBubble() {
   int minimum_menu_width = GetMinimumMenuWidth();
   should_block_shelf_auto_hide_ = true;
   views::TrayBubbleView::InitParams init_params(
       GetAnchorAlignment(), minimum_menu_width, minimum_menu_width);
   init_params.can_activate = true;
   init_params.close_on_deactivate = true;
 
@@ skipping 51 matching lines @@
   // Overrides the keyboard url ref to make it shown with the given keyset.
   if (InputMethodManager::Get())
     InputMethodManager::Get()->OverrideKeyboardUrlRef(keyset);
 
   // If onscreen keyboard has been enabled, shows the keyboard directly.
   keyboard::KeyboardController* keyboard_controller =
       keyboard::KeyboardController::GetInstance();
   show_keyboard_ = true;
   if (keyboard_controller) {
     keyboard_controller->AddObserver(this);
-    keyboard_controller->ShowKeyboard(false);
+    // If the keyboard window hasn't been created yet, it means the extension
+    // cannot receive anything to show the keyboard. Therefore, instead of
+    // relying the extension to show the keyboard, forcibly show the keyboard
+    // window here (which will cause the keyboard window created).

[bshe, 2016/12/29 19:22:15]

The comment here is not very clear. It looks like you prevent showing keyboard
on native side if keyboard window is already created. I am assuming this is
because you want extension to call private api to show keyboard so you skip it
here. Perhaps reword your comment here.

[Azure Wei, 2017/01/03 03:37:40]

Updated the comment here.

+    if (!keyboard_controller->IsKeyboardWindowCreated()) {
+      keyboard_controller->ShowKeyboard(false);
+    }
     return;
   }
 
   AccessibilityDelegate* accessibility_delegate =
       WmShell::Get()->accessibility_delegate();
   // Fails to show the keyboard.
   if (accessibility_delegate->IsVirtualKeyboardEnabled())
     return;
 
   // Onscreen keyboard has not been enabled yet, forces to bring out the
@@ skipping 95 matching lines @@
 
 void ImeMenuTray::HideBubble(const views::TrayBubbleView* bubble_view) {
   HideBubbleWithView(bubble_view);
 }
 
 void ImeMenuTray::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {}
 
 void ImeMenuTray::OnKeyboardClosed() {
   if (InputMethodManager::Get())
     InputMethodManager::Get()->OverrideKeyboardUrlRef(std::string());
+  keyboard::KeyboardController* keyboard_controller =
+      keyboard::KeyboardController::GetInstance();
+  if (keyboard_controller)
+    keyboard_controller->RemoveObserver(this);
+
   show_keyboard_ = false;
   force_show_keyboard_ = false;
 }
 
 void ImeMenuTray::OnKeyboardHidden() {
   if (!show_keyboard_)
     return;
 
   // If the the IME menu has overriding the input view url, we should write it
   // back to normal keyboard when hiding the input view.
@@ skipping 25 matching lines @@
   WmShell::Get()->system_tray_delegate()->GetCurrentIME(&current_ime_);
 
   // Updates the tray label based on the current input method.
   if (current_ime_.third_party)
     label_->SetText(current_ime_.short_name + base::UTF8ToUTF16("*"));
   else
     label_->SetText(current_ime_.short_name);
 }
 
 }  // namespace ash