Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(109)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: services/device/README
Issue
2603553002
:
Ports VRService to be hosted in the device service.
Patch Set: Ports VRService to be hosted in the device service.
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/browser/BUILD.gn
content/browser/DEPS
content/browser/frame_host/render_frame_host_impl.cc
content/public/app/mojo/content_browser_manifest.json
content/public/app/mojo/content_renderer_manifest.json
services/device/BUILD.gn
services/device/README
services/device/device_service.h
services/device/device_service.cc
services/device/manifest.json
third_party/WebKit/Source/modules/vr/BUILD.gn
third_party/WebKit/Source/modules/vr/DEPS
third_party/WebKit/Source/modules/vr/VRController.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« services/device/BUILD.gn
('k') |
services/device/device_service.h »
('j') |
services/device/manifest.json »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
We have one device service and it is hosted in the browser process now.
2
Decoupling some of the sub-modules out of browser process is quite hard
3
especially for those implementation for Android platform.
4
5
One example is VR: The //chrome/browser/android/vr_shell/ uses //device/vr
6
directly, while the corresponding Java layer code (VrShellImpl.java) has to
7
live in browser process. So, VR is coupled to browser process. It is tracked
8
by issue crbug.com/680518.
OLD
NEW
« no previous file with comments
|
« services/device/BUILD.gn
('k') |
services/device/device_service.h »
('j') |
services/device/manifest.json »
('J')
Issue 2603553002: Ports VRService to be hosted in the device service.
Created 3 years, 12 months ago by ke.he
Modified 3 years, 7 months ago
Reviewers: blundell, bajones, mthiesse
Base URL:
Comments: 3
This is Rietveld
408576698