Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: Source/platform/scroll/ScrollableArea.h

Issue 260353003: isActiveFocus() is a more meaningful name (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/scroll/FramelessScrollView.cpp ('k') | Source/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 // This getter will create a ScrollAnimator if it doesn't already exist. 108 // This getter will create a ScrollAnimator if it doesn't already exist.
109 ScrollAnimator* scrollAnimator() const; 109 ScrollAnimator* scrollAnimator() const;
110 110
111 // This getter will return null if the ScrollAnimator hasn't been created ye t. 111 // This getter will return null if the ScrollAnimator hasn't been created ye t.
112 ScrollAnimator* existingScrollAnimator() const { return m_scrollAnimator.get (); } 112 ScrollAnimator* existingScrollAnimator() const { return m_scrollAnimator.get (); }
113 113
114 const IntPoint& scrollOrigin() const { return m_scrollOrigin; } 114 const IntPoint& scrollOrigin() const { return m_scrollOrigin; }
115 bool scrollOriginChanged() const { return m_scrollOriginChanged; } 115 bool scrollOriginChanged() const { return m_scrollOriginChanged; }
116 116
117 // FIXME(bokan): Meaningless name, rename to isActiveFocus 117 virtual bool isActiveFocus() const = 0;
118 virtual bool isActive() const = 0;
119 virtual int scrollSize(ScrollbarOrientation) const = 0; 118 virtual int scrollSize(ScrollbarOrientation) const = 0;
120 virtual void invalidateScrollbar(Scrollbar*, const IntRect&); 119 virtual void invalidateScrollbar(Scrollbar*, const IntRect&);
121 virtual bool isScrollCornerVisible() const = 0; 120 virtual bool isScrollCornerVisible() const = 0;
122 virtual IntRect scrollCornerRect() const = 0; 121 virtual IntRect scrollCornerRect() const = 0;
123 virtual void invalidateScrollCorner(const IntRect&); 122 virtual void invalidateScrollCorner(const IntRect&);
124 virtual void getTickmarks(Vector<IntRect>&) const { } 123 virtual void getTickmarks(Vector<IntRect>&) const { }
125 124
126 // Convert points and rects between the scrollbar and its containing view. 125 // Convert points and rects between the scrollbar and its containing view.
127 // The client needs to implement these in order to be aware of layout effect s 126 // The client needs to implement these in order to be aware of layout effect s
128 // like CSS transforms. 127 // like CSS transforms.
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // vertical-lr / ltr NO NO 279 // vertical-lr / ltr NO NO
281 // vertical-lr / rtl NO YES 280 // vertical-lr / rtl NO YES
282 // vertical-rl / ltr YES NO 281 // vertical-rl / ltr YES NO
283 // vertical-rl / rtl YES YES 282 // vertical-rl / rtl YES YES
284 IntPoint m_scrollOrigin; 283 IntPoint m_scrollOrigin;
285 }; 284 };
286 285
287 } // namespace WebCore 286 } // namespace WebCore
288 287
289 #endif // ScrollableArea_h 288 #endif // ScrollableArea_h
OLDNEW
« no previous file with comments | « Source/platform/scroll/FramelessScrollView.cpp ('k') | Source/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698