Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/security_interstitials/core/controller_client.h

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)
Patch Set: nit, refind comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/security_interstitials/content/security_interstitial_controller_client.cc ('K') | « components/security_interstitials/content/security_interstitial_page.cc ('k') | components/security_interstitials/core/safe_browsing_error_ui.h » ('j') | components/security_interstitials/core/safe_browsing_error_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 8acbf35458d2165ac36d1044e76b0cb1bc7dd179..6ae08914c8787fe4b61e76f44be44fdcda7f29c8 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -89,8 +89,9 @@ class ControllerClient {
virtual PrefService* GetPrefService() = 0;
- protected:
virtual const std::string& GetApplicationLocale() = 0;
meacer 2016/12/27 23:22:34 nit: const method
Jialiu Lin 2016/12/28 18:30:00 Done.
+
+ protected:
virtual const std::string GetExtendedReportingPrefName() = 0;
meacer 2016/12/27 23:22:34 const method
Jialiu Lin 2016/12/28 18:30:00 Done.
private:
« components/security_interstitials/content/security_interstitial_controller_client.cc ('K') | « components/security_interstitials/content/security_interstitial_page.cc ('k') | components/security_interstitials/core/safe_browsing_error_ui.h » ('j') | components/security_interstitials/core/safe_browsing_error_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698