Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5392)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)
Patch Set: nit, refind comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.h ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | components/security_interstitials/content/security_interstitial_controller_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index e94a43b55b2ad8d3141049dea0f6cdc31e65ba26..b92ab331e3f5ffd443daf199de98945d94cf7bba 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -187,9 +187,11 @@ SSLBlockingPage::SSLBlockingPage(
bool overridable,
std::unique_ptr<ChromeMetricsHelper> metrics_helper,
const base::Callback<void(content::CertificateRequestResultType)>& callback)
- : SecurityInterstitialPage(web_contents,
- request_url,
- std::move(metrics_helper)),
+ : SecurityInterstitialPage(
+ web_contents,
+ request_url,
+ base::MakeUnique<ChromeControllerClient>(
+ web_contents, std::move(metrics_helper))),
callback_(callback),
ssl_info_(ssl_info),
overridable_(overridable),
« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.h ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | components/security_interstitials/content/security_interstitial_controller_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698