chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc - Issue 2603433002: Move SecurityInterstitialPage into component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)

Patch Set: nit, refind comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

diff --git a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

index ad459dd348a70f0c577b9521b0bc231499e2df92..3fe9c325ae887e192fcbc8f61e07082d5685b089 100644

--- a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

+++ b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

@@ -323,7 +323,7 @@ IN_PROC_BROWSER_TEST_F(CaptivePortalBlockingPageTest, CertReportingOptOut) {

class CaptivePortalBlockingPageIDNTest : public SecurityInterstitialIDNTest {

protected:

// SecurityInterstitialIDNTest implementation

- SecurityInterstitialPage* CreateInterstitial(

+ security_interstitials::SecurityInterstitialPage* CreateInterstitial(

content::WebContents* contents,

const GURL& request_url) const override {

net::SSLInfo empty_ssl_info;