chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 2603433002: Move SecurityInterstitialPage into component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)

Patch Set: nit, refind comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/ssl/bad_clock_blocking_page.h » ('j') | components/security_interstitials/content/security_interstitial_controller_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

index 0376620a6251cc382a5feb60a5c58446e1e55a64..ee4ae7844c75fd14aac4d7de2f09940dc0cef50c 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

@@ -637,7 +637,7 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsDisabled) {

ShowInterstitial(false, kBadURL);

SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();

ASSERT_TRUE(sb_interstitial);

- EXPECT_TRUE(sb_interstitial->CanShowExtendedReportingOption());

+ EXPECT_TRUE(sb_interstitial->sb_error_ui_->CanShowExtendedReportingOption());

base::RunLoop().RunUntilIdle();

@@ -671,7 +671,7 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsToggling) {

ShowInterstitial(false, kBadURL);

SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();

ASSERT_TRUE(sb_interstitial);

- EXPECT_TRUE(sb_interstitial->CanShowExtendedReportingOption());

+ EXPECT_TRUE(sb_interstitial->sb_error_ui_->CanShowExtendedReportingOption());

base::RunLoop().RunUntilIdle();

@@ -707,7 +707,7 @@ TEST_F(SafeBrowsingBlockingPageTest,

ShowInterstitial(false, kBadURL);

SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();

ASSERT_TRUE(sb_interstitial);

- EXPECT_FALSE(sb_interstitial->CanShowExtendedReportingOption());

+ EXPECT_FALSE(sb_interstitial->sb_error_ui_->CanShowExtendedReportingOption());

base::RunLoop().RunUntilIdle();

@@ -741,7 +741,7 @@ TEST_F(SafeBrowsingBlockingPageTest,

ShowInterstitial(false, kBadURL);

SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();

ASSERT_TRUE(sb_interstitial);

- EXPECT_FALSE(sb_interstitial->CanShowExtendedReportingOption());

+ EXPECT_FALSE(sb_interstitial->sb_error_ui_->CanShowExtendedReportingOption());

base::RunLoop().RunUntilIdle();