chrome/browser/interstitials/security_interstitial_page_test_utils.cc - Issue 2603433002: Move SecurityInterstitialPage into component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/interstitials/security_interstitial_page_test_utils.cc

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)

Patch Set: nit, refind comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/interstitials/security_interstitial_page_test_utils.h ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | components/security_interstitials/content/security_interstitial_controller_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/interstitials/security_interstitial_page_test_utils.cc

diff --git a/chrome/browser/interstitials/security_interstitial_page_test_utils.cc b/chrome/browser/interstitials/security_interstitial_page_test_utils.cc

index 889d7cff23e1881b77828b2fdbdeec9b6349e029..4cbc4c2f41a24d7d8252aec41ad08ce692651532 100644

--- a/chrome/browser/interstitials/security_interstitial_page_test_utils.cc

+++ b/chrome/browser/interstitials/security_interstitial_page_test_utils.cc

@@ -7,12 +7,12 @@

#include <string>

#include "base/strings/stringprintf.h"

-#include "chrome/browser/interstitials/security_interstitial_page.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/pref_names.h"

#include "components/prefs/pref_service.h"

+#include "components/security_interstitials/content/security_interstitial_page.h"

#include "components/security_interstitials/core/controller_client.h"

#include "content/public/browser/interstitial_page.h"

#include "content/public/browser/web_contents.h"

@@ -57,7 +57,7 @@ testing::AssertionResult SecurityInterstitialIDNTest::VerifyIDNDecoded() const {

content::WebContents* contents =

browser()->tab_strip_model()->GetActiveWebContents();

DCHECK(contents);

- SecurityInterstitialPage* blocking_page =

+ security_interstitials::SecurityInterstitialPage* blocking_page =

CreateInterstitial(contents, request_url);

blocking_page->Show();